Don't try to keep state in a cell renderer between two paint calls. It

        * gtk/gtkcellrendererprogress.c (gtk_cell_renderer_progress_set_pulse):
        Don't try to keep state in a cell renderer between two paint
        calls. It doesn't work. Patch by Kristian Mueller

svn path=/trunk/; revision=21890

diff --git a/ChangeLog b/ChangeLog
index 75b6f85b0365158ceed4df48f4289266125a2ad6..ef9e5106cdcca8ca45f504d292305019abbd460e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2008-12-13  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 563158 – CellRendererProgress pulsing and progressing rows can 
+       not be used together
+
+       * gtk/gtkcellrendererprogress.c (gtk_cell_renderer_progress_set_pulse):
+       Don't try to keep state in a cell renderer between two paint
+       calls. It doesn't work. Patch by Kristian Mueller
+
 2008-12-13  Matthias Clasen  <mclasen@redhat.com>
 
        Bug 555560 – gtk_combo_box_set_active fails with no model

diff --git a/gtk/gtkcellrendererprogress.c b/gtk/gtkcellrendererprogress.c
index 3dec5b758d0568adaf533c4b35d023256fde515b..08a7e9ae82f83f2617defd85f9f878415e08379e 100644 (file)
--- a/gtk/gtkcellrendererprogress.c
+++ b/gtk/gtkcellrendererprogress.c
@@ -396,10 +396,10 @@ gtk_cell_renderer_progress_set_pulse (GtkCellRendererProgress *cellprogress,
 
    if (pulse != priv->pulse)
      {
-       if (priv->pulse <= 0)
+       if (pulse <= 0)
          priv->offset = 0;
        else
-         priv->offset++;
+         priv->offset = pulse;
      }
 
    priv->pulse = pulse;